Replace Helvetica Neue with Open-Source Font#24
Closed
woodrowbarlow wants to merge 1 commit into
Closed
Conversation
Helvetica Neue is a proprietary font. Redistributing it in this way is not considered fair use. This commit removes the Helvetica Neue fonts from the repository and instead includes Roboto. It is written in such a way that if you copy the Helvetica Neue fonts back into the fonts/ directory (under a `helvetica-neue` subfolder) they will be used as the primary font instead of Roboto.
Author
|
here is a font comparison, for your benefit: |
khassel
pushed a commit
that referenced
this pull request
May 6, 2026
**[#24](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/24) – `js/class.js`** `fnTest` works by serialising a function to a string and checking if `"xyz"` appears in it - the function is never actually called. The bare `xyz;` is never executed, so CodeQL is right to flag it. `return xyz;` makes the intent clear. So this is purely a cosmetic change. **[#26](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/26) – `tests/e2e/helpers/global-setup.js`** CodeQL flagged `if (exec) exec;` as a useless expression - and it was right. But the real find was one level deeper. `startApplication` hardcoded `const port = 8080`, so `MM_PORT` was always overwritten before the app started. The test named "Set port 8100 on environment variable MM_PORT" was actually testing port 8080 the whole time - it just happened to pass anyway. Removed the dead `exec` parameter, made `startApplication` read `MM_PORT` from the environment, and fixed the test so it actually checks what it says it checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helvetica Neue is a proprietary font. Redistributing it in this
way is not considered fair use. This commit removes the Helvetica
Neue fonts from the repository and instead includes Roboto. It is
written in such a way that if you copy the Helvetica Neue fonts
back into the
fonts/directory (under ahelvetica-neuesubfolder)they will be used as the primary font instead of Roboto.
This addresses issue #23